Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(datasets) Fix Flower Datasets docs redirects and formatting #3929

Merged
merged 5 commits into from
Jul 26, 2024
Merged

docs(datasets) Fix Flower Datasets docs redirects and formatting #3929

merged 5 commits into from
Jul 26, 2024

Conversation

adam-narozniak
Copy link
Contributor

@adam-narozniak adam-narozniak commented Jul 26, 2024 •
edited
Loading

Issue

  • misformatted links in tutorial-use-partitioners
  • incorrectly specified redirect map
  • incorrectly rendered bullet list in quickstart-tutorial

Proposal

Apply fixes.

  • Don't apply links to the text with ` ` syntax
  • drop the ".html" form the redirect map keys
  • separate by a new line each bullet point in the bullet list

@adam-narozniak adam-narozniak changed the title Fix fds docs docs(datasets) Fix Flower Datasets docs Jul 26, 2024
@jafermarq jafermarq enabled auto-merge (squash) July 26, 2024 16:03
@jafermarq jafermarq merged commit 693ff06 into main Jul 26, 2024
38 checks passed
@jafermarq jafermarq deleted the fix-fds-docs branch July 26, 2024 16:12
@adam-narozniak adam-narozniak changed the title docs(datasets) Fix Flower Datasets docs docs(datasets) Fix Flower Datasets docs redirects and formatting Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-narozniak @jafermarq